Fix poll_oneoff's handling of non-regular files.#6258
Merged
sunfishcode merged 1 commit intoApr 21, 2023
Merged
Conversation
`poll_oneoff` uses `system_interface::ReadReady` to compute how many bytes are ready to be read, which is part of the Preview1 `poll_oneoff` API. This updates to system-interface 0.25.7 which has a fix to handle special files such as /dev/urandom and /dev/null properly. Fixes bytecodealliance#6239.
pchickey
approved these changes
Apr 20, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Apr 28, 2023
…6258) `poll_oneoff` uses `system_interface::ReadReady` to compute how many bytes are ready to be read, which is part of the Preview1 `poll_oneoff` API. This updates to system-interface 0.25.7 which has a fix to handle special files such as /dev/urandom and /dev/null properly. Fixes bytecodealliance#6239.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poll_oneoffusessystem_interface::ReadReadyto compute how many bytes are ready to be read, which is part of the Preview1poll_oneoffAPI. This updates to system-interface 0.25.7 which has a fix to handle special files such as /dev/urandom and /dev/null properly.Fixes #6239.